Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update surface albedo in TUV-x prior to calculating rate constants #96

Closed
mattldawson opened this issue Jun 17, 2024 · 0 comments
Closed

Update surface albedo in TUV-x prior to calculating rate constants #96

mattldawson opened this issue Jun 17, 2024 · 0 comments
Assignees
@boulderdaze
Milestone
MICM, TUV-x in CA...

Comments

@mattldawson
Copy link
Collaborator

Update the profile of surface albedos in TUV-x for each column prior to calculating photolysis rate constants.

Acceptance Criteria

  • TUV-x photolysis rate constants are calculated for the actual surface albedos for each column at each timestep

Ideas
@mattldawson mattldawson added this to the MICM, TUV-x in CAM-SIMA milestone Jun 17, 2024
@boulderdaze boulderdaze self-assigned this Sep 11, 2024
@boulderdaze boulderdaze mentioned this issue Oct 18, 2024
Merged
boulderdaze added a commit that referenced this issue Oct 30, 2024
@boulderdaze @mattldawson
Update surface albedo in TUV-x prior to calculating rate constants (#141
862ac09 
)

Originator(s): @mattldawson, @boulderdaze

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue
number):
- Updates TUV-x wrapper, tests, and configuration data to allow setting
the wavelength grid from the host model. This implementation assumes
that there will be a standard-named variable that defines the edges of
the wavelength grid to use for photolysis rate constant calculations
that is defined by the host model.
- Updates the profile of surface albedos in TUV-x for each column prior
to calculating photolysis rate constants.
- Closes #96 and #123

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do:
- A       schemes/musica/tuvx/musica_ccpp_tuvx_surface_albedo.F90
- A       schemes/musica/tuvx/musica_ccpp_tuvx_util.F90
- A       schemes/musica/tuvx/musica_ccpp_tuvx_wavelength_grid.F90
- A       test/musica/tuvx/test_tuvx_surface_albedo.F90
- A       test/musica/tuvx/test_tuvx_wavelength_grid.F90

List all existing files that have been modified, and describe the
changes:
- M       schemes/musica/musica_ccpp.F90
- M       schemes/musica/musica_ccpp.meta
- M       schemes/musica/tuvx/musica_ccpp_tuvx.F90
- M       test/musica/micm/test_micm_util.F90
- M       test/musica/test_musica_api.F90
- M       test/musica/tuvx/CMakeLists.txt
- M       test/musica/tuvx/configs/ts1_tsmlt.json
- M       test/musica/tuvx/test_tuvx_height_grid.F90
- M       test/musica/tuvx/test_tuvx_temperature.F90

List any test failures: N/A

Is this a science-changing update? New physics package, algorithm
change, tuning changes, etc? No

---------

Co-authored-by: Matt Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boulderdaze boulderdaze

Labels
None yet
Projects
None yet
Milestone
MICM, TUV-x in CAM-SIMA
Development

No branches or pull requests
2 participants
@mattldawson @boulderdaze