Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure metadata is correct #120

Closed
boulderdaze opened this issue Sep 24, 2024 · 1 comment
Closed

Add test to ensure metadata is correct #120

boulderdaze opened this issue Sep 24, 2024 · 1 comment
Assignees
@boulderdaze

Comments

@boulderdaze
Copy link
Collaborator

boulderdaze commented Sep 24, 2024 •
edited by mattldawson
Loading

Mock host model for testing physics schemes that includes the CCPP code generation step to ensure the metadata is correct

Acceptance Criteria

  • Test the metadata against the source code
  • Add an automated checker that validates the standard names against the source code
  • Check the standard names against the official dictionary

Ideas
@boulderdaze boulderdaze self-assigned this Sep 24, 2024
@boulderdaze
Copy link
Collaborator Author

boulderdaze commented Oct 16, 2024 •
edited
Loading

PR 134 includes testing metadata against the source code

@boulderdaze boulderdaze mentioned this issue Nov 12, 2024
Closed
@boulderdaze boulderdaze mentioned this issue Nov 21, 2024
Merged
boulderdaze added a commit that referenced this issue Nov 26, 2024
@boulderdaze @mattldawson
Validates the MUSICA meta data against the CCPP standard names (#162)
01e619f 
Originator(s): @boulderdaze

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue
number):
- Add an automated checker that validates the MUSICA meta data against
the CCPP standard names
- Closes #120 

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do:  N/A

List all existing files that have been modified, and describe the
changes:
```
M   doc/NamesNotInDictionary.txt
M   schemes/musica/musica_ccpp_namelist.xml
M   test/docker/Dockerfile.musica
M   test/docker/Dockerfile.musica.no_install
M   test/musica/CMakeLists.txt
```
List any test failures: N/A

Is this a science-changing update? New physics package, algorithm
change, tuning changes, etc? No

---------

Co-authored-by: Matt Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boulderdaze boulderdaze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boulderdaze