Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version string on CTSM surface datasets to check for compatability #2723

Closed
ekluzek opened this issue Aug 22, 2024 · 3 comments · Fixed by #2500
Closed

Version string on CTSM surface datasets to check for compatability #2723

ekluzek opened this issue Aug 22, 2024 · 3 comments · Fixed by #2500
Assignees
Labels
bfb bit-for-bit usability Improve or clarify user-facing options
Milestone

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 22, 2024

CTSM5.3.0 datasets will NOT be compatible with CTSM5.2.0 datasets. In CTSM5.2.0 which had a similar problem, we handled this by checking for existence of the PCT_OCEAN field. In this case it won't be so easy to do a similar check.

So that resurrects an idea we had for CTSM5.2....

Another idea is to have a version string as a global attribute on the files to check for compatibility. If the string doesn't match what's expected then it dies with an error. This can then be updated anytime we have something that is NOT backward compatible.

Originally posted by @ekluzek in #2218 (comment)

@wwieder
Copy link
Contributor

wwieder commented Aug 29, 2024

This is likely the most critical piece to be added, making sure we get the right surface data with the right version of the code. @ekluzek this is your top priority for remaining 5.3 milestones.

@slevis-lmwg
Copy link
Contributor

The current error message when using a pre-5.3 dataset is posted here:
#2500 (comment)

@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 5, 2024

Error message now looks like:

 Input surface dataset is: 
 /glade/work/erik/ctsm_worktrees/quickfix/cime/scripts/SMS_D_Ld1_PS.f09_g17.I185
 0Clm50Sp.derecho_intel.clm-default.20240830_132945_zua8jc/surfdata_0.9x1.25_sim
 yr1850_c130927.nc
This surface dataset is older than 4.5 and incompatible with this version of CTSM
Dataset version = 0.0 Version expected = 5.3
 ERROR in surfrdMod.F90 at line 106                                             
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                                       
 ENDRUN:
 ERROR: ERROR: Incompatible surface dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit usability Improve or clarify user-facing options
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants