Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fire code #2714

Open
samsrabin opened this issue Aug 20, 2024 · 0 comments
Open

Refactor fire code #2714

samsrabin opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
code health improving internal code structure to make easier to maintain (sustainability) size: large Large project that will take a few weeks or more

Comments

@samsrabin
Copy link
Collaborator

samsrabin commented Aug 20, 2024

The fire code could use some love:

  • Minimize duplicated code among modules
  • Reduce the number of modules
  • Break up large functions
  • Get rid of magic numbers
  • Minimize number of running means (see this comment)
  • Improve commenting
  • Improve whitespace

This should wait until this summer's fire updates are complete, and probably also until Fang's multi-day burning code has been implemented.

@samsrabin samsrabin added code health improving internal code structure to make easier to maintain (sustainability) size: large Large project that will take a few weeks or more labels Aug 20, 2024
@samsrabin samsrabin added this to the ctsm6.0.0 (code freeze) milestone Aug 20, 2024
@samsrabin samsrabin self-assigned this Aug 20, 2024
@samsrabin samsrabin moved this to Todo (post-chill) in CTSM: Fire updates 2024 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability) size: large Large project that will take a few weeks or more
Projects
Status: Todo (post-chill)
Development

No branches or pull requests

1 participant