Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File written by hist_printflds is missing some fields #1499

Closed
billsacks opened this issue Sep 24, 2021 · 0 comments · Fixed by #2044
Closed

File written by hist_printflds is missing some fields #1499

billsacks opened this issue Sep 24, 2021 · 0 comments · Fixed by #2044
Labels
bfb bit-for-bit bug something is working incorrectly

Comments

@billsacks
Copy link
Member

Brief summary of bug

I noticed that the file written by the hist_printflds routine (e.g., master_list_nofates.rst) is missing some fields.

General bug information

CTSM version you are using: ctsm5.1.dev057

Does this bug cause significantly incorrect results in the model's science? NO

Configurations affected: ??

Details of bug

I noticed that all of the PCT_* fields (defined in subgridWeightsMod) are missing from https://github.com/ESCOMP/CTSM/blob/master/doc/source/users_guide/setting-up-and-running-a-case/master_list_nofates.rst and from the file in the test, ERP_P36x2_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.cheyenne_gnu.clm-extra_outputs, even though they are present in the history file for that test. I haven't looked to see if any other fields may be affected.

The problem is that hist_printflds is called a little too early in initialization – before init_subgrid_weights_mod and possibly before other relevant subroutines. This could probably be safely moved to the end of initialize2.

We should move that routine, then regenerate the documentation from these history field lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit bug something is working incorrectly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants