use mesh file instead of grid name #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvertens
approved these changes
Apr 20, 2022
junwang-noaa
pushed a commit
to NOAA-EMC/CMEPS
that referenced
this pull request
Jun 9, 2022
* add new flux computation for UFS model and add new coupling mode for exchange grid implementation * fix area field for new flux algorithm * send fluxes to atmospheric model * initial implementation for sending fluxes to UFS ATM * update CCPP host model * fix latent and sensible heat fluxes and clean code * add new coupling mode for side by side flux comparison * fix CCPP host model for latent and sensible heat fluxes * fix aoflux calculation on agrid and add missing error checks * add option to write meshes and update code that retrieve area information from xgrid * update ccpp host based on recent changes in ccpp framework * fix for providing cell area to CCPP host model * make ccpp physics options configurable * Refactor nems field exchange; set default masks for mapping in med_internalstate (ESCOMP#279) Refactors esmFldsExchange_nems.F90 to use separate advertise and initialize phases and to check that a component is present before advertising a field to or from that component. Implements default src and dst mask values in place of the code currently in med_map_mod.F90. Fixes #63 and #64. * use mesh file instead of grid name (ESCOMP#285) This was done so that vertical component used in grid name does not affect tests. Co-authored-by: Dom Heinzeller <[email protected]> Co-authored-by: Francis Vitt <[email protected]> Co-authored-by: Courtney Peverley <[email protected]> Co-authored-by: Jim Edwards <[email protected]> Co-authored-by: mvertens <[email protected]> Co-authored-by: Denise Worthen <[email protected]> Co-authored-by: Mariana Vertenstein <[email protected]> Co-authored-by: Ufuk Turuncoglu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Use comparisons of Mesh file instead of grid to determine if components are on the same grid.
This was done so that vertical component used in grid name does not affect this test.
Specific notes
Contributors other than yourself, if any: mvertens
CMEPS Issues Fixed: #284
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Testing performed if application target is CESM:
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: