Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor mediator history to permit new functionality #228

Merged
merged 76 commits into from
Oct 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
5903c0f
fixed bug for running in clm single column mode
Jul 31, 2020
1b2a6ff
updates to be consistent with mct
Aug 1, 2020
30377d5
updates to be more consistent with cpl7
Aug 6, 2020
5b23e22
removed commented sections
Aug 7, 2020
2580aff
changes needed to get aux_cam_tests to work
Aug 22, 2020
d7c0849
fixes necessary to run preapha tests
Aug 27, 2020
0f835b8
updates needed for aux_pop and bug fixes
Aug 29, 2020
efe4f43
first addition to adding auxiliary history files
Aug 31, 2020
9d25908
more updates for auxiliary files
Sep 3, 2020
f1daa88
changes needed for auxiliary files
Sep 6, 2020
8e8ae93
added alarms to trigger aux file updates
Sep 7, 2020
69291a3
updates for getting average history files to work
Sep 8, 2020
1f40c69
updates for time averaging
Sep 8, 2020
2de7942
updates to get time bounds correct
Sep 10, 2020
7cdb56c
updates for history phase names
Sep 11, 2020
8dfe3f4
more updates for auxiliary file writes
Sep 13, 2020
c6abde0
more cleanup of aux files
Sep 21, 2020
8676c3b
updates to get aux files working with new per file clock
Oct 6, 2020
9379c0c
updates to merge to mvertens/perf PR changes
Oct 30, 2020
bf66ead
updates to latest mvertens/perf
Nov 1, 2020
03a1d87
more updates to mvertens/perf
Nov 1, 2020
be86f60
refact of time averaged output
Nov 1, 2020
5d6c344
removal of more calls to med_methods_mod
Nov 3, 2020
d7e47c1
Merge branch 'master' into mvertens/history_updates2
Nov 3, 2020
43ceadc
update to v0.9.0
Apr 10, 2021
60dad99
verified that instantaneous output works
Apr 12, 2021
3486a60
compression of inst, avg and aux for a given component into one run p…
Apr 14, 2021
662cbe4
cleanup of namelists and setting of aux enabled flags to logical
Apr 14, 2021
dd39e8d
more general implementation of multiple ice sheets
Apr 15, 2021
1adf5d0
updates for prep glc phase
Apr 26, 2021
fccfd3f
Merge branch 'master' into features/history_updates
Apr 26, 2021
08f18b5
Merge remote-tracking branch 'MV/features/history_updates' into featu…
DeniseWorthen Jul 15, 2021
2198e53
Merge remote-tracking branch 'escomp/master' into feature/history_upd…
DeniseWorthen Jul 15, 2021
215bc3b
add albedo fields ice->atm
DeniseWorthen Jul 16, 2021
ac0ef28
change order of history options in config
DeniseWorthen Jul 20, 2021
4445e35
propagate name changes
DeniseWorthen Jul 20, 2021
89c720f
white space and config changes
DeniseWorthen Jul 21, 2021
3cdfe02
wrap long line
DeniseWorthen Jul 21, 2021
12681eb
Merge remote-tracking branch 'origin/feature/add_albedos' into featur…
DeniseWorthen Jul 21, 2021
9b53ff7
make diag_init optional
DeniseWorthen Jul 22, 2021
7e9b3f0
Merge branch 'emc/develop' into feature/history_updates_add_albedos
DeniseWorthen Jul 29, 2021
5826e50
Merge branch 'NOAA-EMC:emc/develop' into feature/history_updates_add_…
DeniseWorthen Aug 11, 2021
4f61758
Merge pull request #1 from DeniseWorthen/feature/history_updates_add_…
mvertens Aug 16, 2021
fde3e01
merge to master
Aug 28, 2021
657ee4b
remote conflict in merge
Aug 28, 2021
5cd0bb2
reverted changes to master versions
Aug 28, 2021
f4b9f2d
revert to master version
Aug 28, 2021
6974330
removed component history phases as run sequence options and moved th…
Aug 29, 2021
4dc835f
more cleanup of new history capability for averaging
Aug 30, 2021
4e6b637
average history file fixes
Aug 30, 2021
6399616
got time average alarms to work correctly
Aug 31, 2021
15e2b9b
refactor of med_io_mod time initialization
Sep 2, 2021
31525e7
more refactoring of history output to enable code reuse
Sep 4, 2021
8d07938
more cleanup
Sep 6, 2021
4c291c4
refactored different write phases to use module datatypes
Sep 7, 2021
dd0a5af
more code reuse introduced in med_phases_history_mod
Sep 8, 2021
9cb2db4
refactored history all write to use model clock
Sep 9, 2021
ff422ba
put in call to mediator history output in med_phases_aofluxes_mod.F90
Sep 10, 2021
6956aeb
merged to head of feature/refactor_accum
Sep 11, 2021
f19485f
Merge branch 'master' into feature/history_refactor
Sep 11, 2021
a8fa999
more cleanup and code sharing
Sep 12, 2021
76a5e48
fixes based on aux_glc testing
Sep 15, 2021
594fd00
updates to have l2x1yr aux file written
Sep 20, 2021
bc07453
updates to clean up med_phases_prep_glc
Sep 20, 2021
6c54e3e
added fixes for multiple ice sheets
Sep 20, 2021
320d751
backed out changes to med_phases_post_gcl
Sep 22, 2021
efb9870
fixed accumulation to rof from lnd restart issue
Sep 22, 2021
6d77bc4
fixed issues with alarms
Sep 24, 2021
f5a319e
refatored inst output mode
Sep 25, 2021
313f0f3
refactored aux and avg history files and restart output
Sep 25, 2021
21a1276
added more debugging info
Sep 26, 2021
a2aecf4
updates to master
Sep 27, 2021
3c5a784
made the F2000 test nuopc rather than mct
Sep 27, 2021
4ed6e9c
refactored testlist
Sep 27, 2021
ef01040
updates required in code review for PR
Oct 13, 2021
ca2ecb3
updates to master
Oct 13, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions cime_config/buildnml
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,6 @@ def _create_drv_namelists(case, infile, confdir, nmlgen, files):
#----------------------------------------------------
nmlgen.init_defaults(infile, config)

if case.get_value('MEDIATOR_READ_RESTART'):
nmlgen.set_value('mediator_read_restart', value='.true.')
else:
nmlgen.set_value('mediator_read_restart', value='.false.')

#--------------------------------
# Overwrite: set brnch_retain_casename
#--------------------------------
Expand Down Expand Up @@ -292,7 +287,7 @@ def _create_drv_namelists(case, infile, confdir, nmlgen, files):
# the driver restart pointer will look like a mediator is present even if it is not
nmlgen.set_value("drv_restart_pointer", value="rpointer.cpl")

logger.info("Writing nuopc_runseq for components {}".format(valid_comps))
logger.info("Writing nuopc_runconfig for components {}".format(valid_comps))
nuopc_config_file = os.path.join(confdir, "nuopc.runconfig")
nmlgen.write_nuopc_config_file(nuopc_config_file, data_list_path=data_list_path)

Expand Down
103 changes: 30 additions & 73 deletions cime_config/config_component.xml
Original file line number Diff line number Diff line change
Expand Up @@ -435,27 +435,6 @@
</values>
</entry>

<entry id="BARRIER_N">
<type>char</type>
<default_value>1</default_value>
<group>run_begin_stop_restart</group>
<file>env_run.xml</file>
<desc>
Sets periodic model barriers with BARRIER_OPTION and BARRIER_DATE for synchronization
</desc>
</entry>

<entry id="BARRIER_DATE">
<type>char</type>
<default_value>-999</default_value>
<group>run_begin_stop_restart</group>
<file>env_run.xml</file>
<desc>
Alternative date in yyyymmdd format
sets periodic model barriers with BARRIER_OPTION and BARRIER_N for synchronization
</desc>
</entry>

<entry id="ESP_RUN_ON_PAUSE">
<type>logical</type>
<valid_values>TRUE,FALSE</valid_values>
Expand Down Expand Up @@ -841,6 +820,21 @@
machines.</desc>
</entry>

<entry id="CLM_USE_PETSC">
<type>logical</type>
<valid_values>TRUE,FALSE</valid_values>
<default_value>FALSE</default_value>
<group>build_component_clm</group>
<file>env_build.xml</file>
<desc>TRUE implies CLM is built with support for the PETSc
library. The Variably Saturated Flow Model (VSFM) solver in CLM
uses the PETSc library. In order to use the VSFM solver, CLM
must be built with PETSc support and linking to PETSc must occur
when building the ACME executable. This occurs if this variable
is set to TRUE. Note that is only available on a limited set of
machines/compilers.</desc>
</entry>

<entry id="USE_MOAB">
<type>logical</type>
<valid_values>TRUE,FALSE</valid_values>
Expand Down Expand Up @@ -2294,10 +2288,6 @@
<desc>standard full pathname of the cprnc executable</desc>
</entry>

<!-- ===================================================================== -->
<!-- component coupling options and frequencies -->
<!-- ===================================================================== -->

<entry id="CPL_I2O_PER_CAT">
<type>logical</type>
<valid_values>TRUE,FALSE</valid_values>
Expand All @@ -2307,38 +2297,6 @@
<desc>determine if per ice thickness category fields are passed from ice to ocean - DO NOT EDIT (set by POP build-namelist)</desc>
</entry>

<!-- ===================================================================== -->
<!-- history frequencies -->
<!-- ===================================================================== -->

<entry id="HIST_OPTION">
<type>char</type>
<valid_values>none,never,nsteps,nstep,nseconds,nsecond,nminutes,nminute,nhours,nhour,ndays,nday,nmonths,nmonth,nyears,nyear,end</valid_values>
<default_value>never</default_value>
<group>run_drv_history</group>
<file>env_run.xml</file>
<desc>Sets driver snapshot history file frequency (like REST_OPTION)</desc>
</entry>

<entry id="HIST_N">
<type>integer</type>
<valid_values></valid_values>
<default_value>-999</default_value>
<group>run_drv_history</group>
<file>env_run.xml</file>
<desc>Sets driver snapshot history file frequency (like REST_N)
</desc>
</entry>

<entry id="HIST_DATE">
<type>integer</type>
<valid_values></valid_values>
<default_value>-999</default_value>
<group>run_drv_history</group>
<file>env_run.xml</file>
<desc>yyyymmdd format, sets coupler snapshot history date (like REST_DATE)</desc>
</entry>

<entry id="INFO_DBUG">
<type>integer</type>
<valid_values>0,1,2,3,4,5,6,7,8,9</valid_values>
Expand All @@ -2348,22 +2306,6 @@
<desc>level of debug output, 0=minimum, 1=normal, 2=more, 3=too much</desc>
</entry>

<entry id="CLM_USE_PETSC">
<type>logical</type>
<valid_values>TRUE,FALSE</valid_values>
<default_value>FALSE</default_value>
<group>build_component_clm</group>
<file>env_build.xml</file>
<desc>TRUE implies CLM is built with support for the PETSc
library. The Variably Saturated Flow Model (VSFM) solver in CLM
uses the PETSc library. In order to use the VSFM solver, CLM
must be built with PETSc support and linking to PETSc must occur
when building the ACME executable. This occurs if this variable
is set to TRUE. Note that is only available on a limited set of
machines/compilers.</desc>
</entry>


<!-- Prerun/postrun custom script options -->

<entry id="PRERUN_SCRIPT">
Expand Down Expand Up @@ -2541,6 +2483,21 @@
<desc>add aoflux calculation to runseq</desc>
</entry>

<!-- ===================================================================== -->
<!-- TODO: the following should be deleted. They are still used by -->
<!-- the component testing but are not doing anything in cmeps -->
<!-- ===================================================================== -->

<entry id="BFBFLAG">
<type>logical</type>
<valid_values>TRUE,FALSE</valid_values>
<default_value>FALSE</default_value>
<group>run_flags</group>
<file>env_run.xml</file>
<desc>turns on coupler bit-for-bit reproducibility with varying pe counts</desc>
</entry>


<help>
=========================================
Notes:
Expand Down
Loading