-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autocomplete & inline mode #422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, proper styling
…te-backspace fix: inline mode improvements
silvester-pari
changed the base branch from
main
to
itemfilter/feature/inline-mode
November 15, 2023 14:57
silvester-pari
changed the base branch from
itemfilter/feature/inline-mode
to
main
November 15, 2023 14:57
Checklist before merging
|
…xElements into itemfilter/feature/autocomplete
This was referenced Nov 16, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an evolution / complete rewrite of #247.
It introduces a few more components in order to make things more manageable:
eox-autocomplete
eox-itemfilter-chips
eox-itemfilter-inline
eox-dropdown
eox-selectionlist
Autocomplete
Used for
select
andmultiselect
filters if number of filter options is greater than 10.Inline mode
Inline mode renders the entire itemfilter into a single input field, including two-step selection (filter/filter value) in a dropdown