Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autocomplete & inline mode #422

Merged
merged 51 commits into from
Nov 16, 2023
Merged

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Nov 15, 2023

This PR is an evolution / complete rewrite of #247.

It introduces a few more components in order to make things more manageable:

eox-autocomplete
eox-itemfilter-chips
eox-itemfilter-inline
eox-dropdown
eox-selectionlist

Autocomplete

Used for selectand multiselect filters if number of filter options is greater than 10.

image

Inline mode

Inline mode renders the entire itemfilter into a single input field, including two-step selection (filter/filter value) in a dropdown
image
image

@silvester-pari silvester-pari changed the base branch from main to itemfilter/feature/inline-mode November 15, 2023 14:57
@silvester-pari silvester-pari changed the base branch from itemfilter/feature/inline-mode to main November 15, 2023 14:57
@silvester-pari
Copy link
Collaborator Author

silvester-pari commented Nov 15, 2023

Checklist before merging

  • fix typescript errors
  • fix input box size (currently overflowing)
  • fix backspace error (when filter is "in progress" then it removes hidden chips withou the user noticing)

@silvester-pari silvester-pari merged commit 10bdf21 into main Nov 16, 2023
3 checks passed
@silvester-pari silvester-pari deleted the itemfilter/feature/autocomplete branch November 16, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants