Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DNT:1 via Chrome setting rather than via request header modification? #474

Closed
qwertie opened this issue Jul 13, 2015 · 4 comments
Closed
Labels
DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy enhancement ui User interface modifications; related to but not the same as the "ux" label wontfix

Comments

@qwertie
Copy link

qwertie commented Jul 13, 2015

I noticed right after installing PB that Do-Not-Track was unchecked in the advanced settings in Chrome. The FAQ seems to imply that PB only blocks sites that don't respect DNT, but it doesn't say how PB behaves in case DNT is off. If PB requires DNT to function, I think it should offer to turn on DNT when first installed. In any case, the FAQ should make it clear how PB behaves if DNT is off.

@pde
Copy link
Contributor

pde commented Jul 13, 2015

Privacy Badger should be attaching the DNT: 1 header to outgoing requests separately from that Chrome setting. If it isn't, that would be a serious bug.

However what we should probably do is set the Chrome DNT setting to "on", and write a hook such that if the user manually turns it off, we can pop up and say "hey, Privacy Badger's theory of relying on dnt-policy.txt to protect you doesn't work if you don't have DNT on".

@pde pde changed the title How does PB behave if the DNT flag is off? Set DNT:1 via Chrome setting rather than via request header modification? Jul 13, 2015
@pde pde added this to the Privacy Badger 2.0 milestone Jul 13, 2015
@pde pde added enhancement ui User interface modifications; related to but not the same as the "ux" label labels Jul 13, 2015
@cooperq cooperq self-assigned this Jul 28, 2015
@cooperq
Copy link
Contributor

cooperq commented Jul 28, 2015

Chrome is attaching this header in the modify web request callback. We are not able to change the setting in chrome until this patch lands:
https://codereview.chromium.org/902653002/
bug report for the issue:
https://code.google.com/p/chromium/issues/detail?id=455288

@cooperq cooperq removed their assignment Jul 28, 2015
@cooperq
Copy link
Contributor

cooperq commented Jul 28, 2015

Another interesting related issue: https://code.google.com/p/chromium/issues/detail?id=447978

@ghostwords
Copy link
Member

ghostwords commented May 31, 2018

The problem with using the WebExtensions API (#1835 (comment)) is that the API is less flexible than doing it ourselves. How would we disable sending DNT on whitelisted sites (#1260)? How would we send DNT=0 signal if we implement the W3C DNT spec (#1230)? And does the browser API support navigator.doNotTrack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy enhancement ui User interface modifications; related to but not the same as the "ux" label wontfix
Projects
None yet
Development

No branches or pull requests

4 participants