Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-indented comment lines causes if- and while- command blocks to end prematurely #860

Closed
1 of 2 tasks
dc42 opened this issue Jun 2, 2023 · 1 comment
Closed
1 of 2 tasks
Assignees
Labels
bug Bug that has been reproduced Documentation
Milestone

Comments

@dc42
Copy link
Collaborator

dc42 commented Jun 2, 2023

Duet Forum Discussion Thread

https://forum.duet3d.com/topic/32583/macro-does-not-properly-recognize-as-a-comment-line

Firmware Version

3.4.0, 3.5.0beta.3

Are you using a Single Board Computer (RaspberryPi) with your Duet?

  • Yes I use a SBC.
  • No I do not use a SBC.

What happened?

In the following macro:

var bedTemp=40
if var.bedTemp < 30
  set global.soakTime = 180
; test  
elif var.bedTemp < 50
  echo "less than 50"

the un-indented "; test" line causes the parser to report that the "elif" line is not within an if-command. It works correctly if the comment line is indented.

@dc42 dc42 added the bug Bug that has been reproduced label Jun 2, 2023
@dc42 dc42 assigned x0rtrunks and dc42 and unassigned x0rtrunks Jun 2, 2023
@dc42 dc42 added this to the 3.5.1 milestone Jun 2, 2023
@dc42 dc42 changed the title In-indented comment lines causes if- and while- command blocks to end prematurely Un-indented comment lines causes if- and while- command blocks to end prematurely Jun 2, 2023
@dc42 dc42 modified the milestones: 3.5.1, 3.5.2 Apr 21, 2024
@T3P3 T3P3 modified the milestones: 3.5.2, After 3.5.2 May 22, 2024
@T3P3 T3P3 modified the milestones: After 3.5.2, 3.6.0 Nov 26, 2024
@dc42
Copy link
Collaborator Author

dc42 commented Dec 9, 2024

Fixed in 3.6-dev ready for beta 3.

@dc42 dc42 closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that has been reproduced Documentation
Projects
None yet
Development

No branches or pull requests

4 participants