Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for Crusader Kings 2 because it does not have launcher-settings.json #89

Open
LordMartron94 opened this issue Oct 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@LordMartron94
Copy link

image
I did click on "quick select game directory"

I have looked through your source code and I believe this is due to checking whether the selected directory can find launcher-settings.json in a recursive manner... The game Crusader Kings 2 does not have this file anywhere. For this specific game, you should not check for the file.

@LordMartron94
Copy link
Author

I made a mock file and that seemed to work (after starting the game and quitting it again)

@DragonKnightOfBreeze DragonKnightOfBreeze added the enhancement New feature or request label Oct 5, 2024
@DragonKnightOfBreeze
Copy link
Owner

any file else can obtain game version?
permit every directory or directory (directly or under game subdirectory) contains .exe as game directory, should not be a good solution ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants