Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings require cycle #1057

Closed
Dennis-96 opened this issue Oct 27, 2020 · 11 comments
Closed

Warnings require cycle #1057

Dennis-96 opened this issue Oct 27, 2020 · 11 comments
Labels

Comments

@Dennis-96
Copy link

Describe the bug
When i run the app i get these warnings and it takes about 5 seconds to enter the app

Require cycle: node_modules\react-native-track-player\lib\index.js->
node_modules\react-native-track-player\lib\hooks.js->
node_modules\react-native-track-player\lib\index.js

node_modules\react-native-track-player\lib\index.js->node_modules\react-native-track-player\lib\ProgressComponent.js->node_modules\react-native-track-player\lib\index.js

To Reproduce
Steps to reproduce the behavior:

Environment (please complete the following information):
Run react-native info in your project and share the content.
What react-native-track-player version are you using?
Are you testing on a real device or in the simulator? Which OS version are you running?

Code
Please, share the code that is causing the issue

@rumax
Copy link

rumax commented Jan 20, 2021

 "react-native-track-player": "^1.2.3",

Issue still actual and quite annoying. Any plans to fix it?

@michaelvitello
Copy link

Hello, I still get these cycle warnings too, that's not ideal. Any plan of fixing them soon? There is other issue opened on the topic that seems to be related. Commenting there too: #989

@Tubaleviao
Copy link

This issue was fixed on PR #1077 and it just need to be merged.

@ghadeeraqraa1992
Copy link

same issue

@curiousdustin
Copy link
Contributor

Fix released in 1.2.4

@dcvz
Copy link
Contributor

dcvz commented Oct 25, 2021

This should be fixed again in the next version of react-native-track-player 4ee2cac

@federicomiralles
Copy link

The require cycle warning is back again, now on version v4.0.1:
Simulator Screenshot - iPhone 13 - 2023-11-20 at 13 51 17

@cuchillitos
Copy link

Issue still present on version 4.0.1

@nl-danish
Copy link

Getting the same issue in 4.0.1.

@karthickraja-saravanan
Copy link

same issue in 4.0.1

@aaronksaunders
Copy link

curious to why this is closed when it is clearly still present?

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle. 
  factory (node_modules/react-native-track-player/lib/web/TrackPlayerModule.js:2:1)
  factory (node_modules/react-native-track-player/lib/web/index.js:1:1)
λ  WARN  Require cycle: node_modules/react-native-track-player/lib/src/index.js -> node_modules/react-native-track-player/lib/src/trackPlayer.js -> node_modules/react-native-track-player/lib/src/TrackPlayerModule.web.js -> node_modules/react-native-track-player/lib/web/index.js -> node_modules/react-native-track-player/lib/web/TrackPlayerModule.js -> node_modules/react-native-track-player/lib/web/TrackPlayer/index.js -> node_modules/react-native-track-player/lib/web/TrackPlayer/PlaylistPlayer.js -> node_modules/react-native-track-player/lib/src/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests