Skip to content
This repository has been archived by the owner on Oct 29, 2020. It is now read-only.

💯 Emoji RB Support #6167

Closed
angaither opened this issue Feb 16, 2016 · 13 comments
Closed

💯 Emoji RB Support #6167

angaither opened this issue Feb 16, 2016 · 13 comments

Comments

@angaither
Copy link
Contributor

Adding emoji kills the reportback submission

image

submitting that returns a 404 for me.

I think this will require us to not use UTF-8 encoding in the db.

https://dosomethingorg1.zendesk.com/agent/tickets/149465
http://www.jeffgeerling.com/blogs/jeff-geerling/solving-emoji-problem-drupal-7

@sheyd
Copy link

sheyd commented Feb 16, 2016

@angaither Adding this in case (and I think we should for sanity of mind), change to actual UTF8 (i.e. utf8mb4) across the 🌐
https://mathiasbynens.be/notes/mysql-utf8mb4

@namimody
Copy link
Contributor

  • edit Thor DB structure
  • edit Thor web app
  • edit prod DB structure
  • deploy
  • change data warehouse to ensure slave replication process still continues to work
  • edit quantum DB

@namimody
Copy link
Contributor

https://www.dosomething.org/admin/reportback/128124 -- dunno what those recycling signs are (emojis?), but interesting they show up in back end and in the caption on the front end...

@angaither angaither added the NO label May 19, 2016
@angaither
Copy link
Contributor Author

closing because we can hope for better days in repo https://github.com/DoSomething/guardian

@namimody
Copy link
Contributor

@angaither does it make sense to move this issue to the Quasar repo?

@ngjo
Copy link
Contributor

ngjo commented Sep 1, 2016

hi @angaither -- @hbghidey and i were just talkinga bout this today! hannah was recreated this issue on mobile (full thread here: https://trello.com/c/vfFRBOiT/1602-users-hitting-404-page) but essentially, when someone submits a RB w/ an emoji over mobile, they get a 404 page and then when they hit back, they see the reportback gallery but then the submission button is gone

is there anything we can do to accept emojis (makes a lot of sense for mobile reporting back, especially), or should we add text in there that tells the user that they can't submit emojis?

@angaither
Copy link
Contributor Author

yup, it's not just mobile, it's anytime emoji is submitted the reportback doesn't go through.
but I'm not sure it makes sense to prioritize this issue in phoenix since we want to move reportbacks to rogue.

@ngjo
Copy link
Contributor

ngjo commented Sep 1, 2016

@jessleenyc
Copy link
Contributor

Would we be able to accept emojis in rogue? Thinking about how this is throwing off our 'pending' reportbacks count.

@angaither
Copy link
Contributor Author

Thinking about how this is throwing off our 'pending' reportbacks count.

these reportbacks wouldn't be pending this is the problem where the reportback id exisits, and there's no file #6765

@ngjo
Copy link
Contributor

ngjo commented Sep 1, 2016

yah -- no need to prioritize, but if that's the case -- i'll sync w/ @hbghidey to include that in the tech macro for the time being to help the member submit w/o emojis (sorrrrrriiieee, no fun emojis 🤑 for youuuuu!!!) thanks!

@mirie
Copy link
Contributor

mirie commented May 18, 2017

We have emoji support in Phoenix-Next and Rogue. We will not be supporting emoji's in Phoenix-Ashes. We already are stripping out emojis from reportbacks per #7014.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

6 participants