ReportbackItemDetailView -(CGFloat)heightForWidth:width #706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #697 - renders Reportback Items with dynamic height in the Campaign Detail view controller.
Instead of using iOS self sizing cells, we manually calculate the height based on xib values in a new
-(CGFloat)heightForWidth:width
method.I've been fighting with getting a sizing cell to return the appropriate height (#687, #688, #694), but it keeps returning sizes that are too large (and the results vary upon each load, making it even trickier).
Reviewed with @pixelrevision -- using good ol' math (similar to what we're already doing in the
LDTCampaignDetailViewController sizeForCellAtIndexPath:
iimplementation) seems just way more understandable and maintable at this point, vs fumbling around in the dark trying to get autolayout to magically calculate the numbers vialayoutSubviews
,layoutIfNeeded
, etc.