Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display network error screen in profile when there's no connection #248

Open
jonuy opened this issue Mar 10, 2016 · 0 comments
Open

Display network error screen in profile when there's no connection #248

jonuy opened this issue Mar 10, 2016 · 0 comments

Comments

@jonuy
Copy link
Collaborator

jonuy commented Mar 10, 2016

What's the problem?

Viewing the profile screen when there's no connection ends up displaying the view for a profile that hasn't taken any actions. There's at least a error popup with a connection error message, but the rest of the view can be misleading - particularly for people who have done a lot of actions.

What's the solution?

When a network error or connection failure or something similar is detected, then display a view that indicates that. Doing something similar to the error view for the news feed would be ideal.

Other notes

Easiest approach to this might be to override and implement GetProfileTask.handleError. And if the error is an instanceof NetworkException or the like, then render an error view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants