Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clihttp): fix context passing in http client #147

Merged
merged 2 commits into from
Jul 2, 2021
Merged

fix(clihttp): fix context passing in http client #147

merged 2 commits into from
Jul 2, 2021

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Jul 2, 2021

No description provided.

@Reasno Reasno requested a review from GGXXLL July 2, 2021 03:03
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #147 (d1eafab) into master (9f81659) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head d1eafab differs from pull request most recent head 6ae2ee8. Consider uploading reports for the commit 6ae2ee8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   80.92%   80.98%   +0.05%     
==========================================
  Files          89       89              
  Lines        3859     3860       +1     
==========================================
+ Hits         3123     3126       +3     
+ Misses        535      533       -2     
  Partials      201      201              
Impacted Files Coverage Δ
clihttp/client.go 60.00% <100.00%> (+0.67%) ⬆️
config/remote/remote.go 85.18% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f81659...6ae2ee8. Read the comment docs.

@Reasno Reasno merged commit c07ee40 into master Jul 2, 2021
@Reasno Reasno deleted the clihttp branch July 2, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants