Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Poloniex trade stream #738

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix Poloniex trade stream #738

merged 1 commit into from
Feb 17, 2022

Conversation

vslee
Copy link
Collaborator

@vslee vslee commented Feb 17, 2022

  • simplified OnGetMarketSymbolsAsync()
  • updated OnGetMarketSymbolsMetadataAsync() to use returnticker endpoint instead
  • changed OnGetTradesWebSocketAsync() to send messageIds instead of symbol names
  • also changed to using epoch_ms instead of timestamp for more precision

@vslee
fix Poloniex trade stream
6f2f1fe 
- simplified OnGetMarketSymbolsAsync()
- updated OnGetMarketSymbolsMetadataAsync() to use returnticker endpoint instead
- changed OnGetTradesWebSocketAsync() to send messageIds instead of symbol names
- also changed to using epoch_ms instead of timestamp for more precision
@vslee vslee requested a review from jjxtra February 17, 2022 02:30
@vslee vslee merged commit ae96858 into DigitalRuby:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjxtra jjxtra jjxtra approved these changes

Assignees
No one assigned
Labels
bug exchange-Poloniex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vslee @jjxtra