Make GetExchangeAPIsAsync return all instances as previous #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major version bump introduced a critical breaking change where GetExchangeAPIsAsync no longer returns a list of all exchanges supported, breaking various integrations. This PR changes the default for GetExchangeAPIsAsync to return all instances but also adds an option to use the current logic
vslee
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major version bump introduced a critical breaking change where GetExchangeAPIsAsync no longer returns a list of all exchanges supported, breaking various integrations. This PR changes the default for GetExchangeAPIsAsync to return all instances but also adds an option to use the current logic
(in fact, the winforms app crashes without this fix)