From 2cc607a8be4a4bdc083e2ceb8fdfdc7e267536e0 Mon Sep 17 00:00:00 2001 From: Tomas Bezouska Date: Fri, 8 Oct 2021 22:33:41 +0200 Subject: [PATCH 1/2] Fix OnGetOrderDetailsAsync --- src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs b/src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs index 21320db6..33497e0c 100644 --- a/src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs +++ b/src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs @@ -288,7 +288,7 @@ protected async override Task OnGetOrderBookAsync(string mark /// protected async override Task OnGetOrderDetailsAsync(string orderId, string marketSymbol = null, bool isClientOrderId = false) { // https://docs.ftx.com/#get-order-status and https://docs.ftx.com/#get-order-status-by-client-id - if (marketSymbol != null) throw new NotImplementedException("Searching by marketSymbol is either not implemented by or supported by this exchange. Please submit a PR if you are interested in this feature"); + if (!string.IsNullOrEmpty(marketSymbol)) throw new NotImplementedException("Searching by marketSymbol is either not implemented by or supported by this exchange. Please submit a PR if you are interested in this feature"); var url = "/orders/"; if (isClientOrderId) From 2ac0005e7cc48ba5564e40c2656bd0f119bb2020 Mon Sep 17 00:00:00 2001 From: Tomas Bezouska Date: Fri, 8 Oct 2021 23:03:58 +0200 Subject: [PATCH 2/2] [FTX] Remove withdrawal tag When the tag is set ftx returns an error --- src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs b/src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs index 33497e0c..bb7708e6 100644 --- a/src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs +++ b/src/ExchangeSharp/API/Exchanges/FTX/ExchangeFTXAPI.cs @@ -339,7 +339,6 @@ protected override async Task OnWithdrawAsync(Exchan { "coin", request.Currency }, { "size", request.Amount }, { "address", request.Address }, - { "tag", request.AddressTag }, { "nonce", await GenerateNonceAsync() }, { "password", request.Password }, { "code", request.Code }