Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to GetOrderDetailsAsync() by ClientOrderId #647

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Added ability to GetOrderDetailsAsync() by ClientOrderId #647

merged 2 commits into from
Sep 18, 2021

Conversation

vslee
Copy link
Collaborator

@vslee vslee commented Sep 16, 2021

  • many, but not all, exchanges support this

@vslee
Added ability to GetOrderDetailsAsync() by ClientOrderId
79ecc3b 
- many, but not all, exchanges support this
@vslee vslee requested a review from jjxtra September 16, 2021 20:34
jjxtra
jjxtra requested changes Sep 18, 2021
View reviewed changes
Copy link
Collaborator

@jjxtra jjxtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr. I request that you move this new optional parameter to the end of the method so that we don't break everyone who updates to this new version.

@vslee
Copy link
Collaborator Author

vslee commented Sep 18, 2021

Done

@vslee vslee merged commit b9659e1 into DigitalRuby:master Sep 18, 2021
@vslee vslee mentioned this pull request Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjxtra jjxtra jjxtra approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vslee @jjxtra