Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dgw): add analytics to gateway standalone #813

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Apr 16, 2024

Enable analytics on Gateway Standalone with OpenSearch.

Place to pay attention to:
There is really no elegant solution to use system environment variables in angular. These env vars are hardcoded in the environment file as suggested by Angular documentation. We could argue that it will be visible to our user in production anyway so it is not a bit deal if we expose it here.

Updated some functions that was originally not used.

Copy link
Contributor

@kristahouse kristahouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pauldumais

This comment was marked as outdated.

@pauldumais pauldumais self-requested a review April 16, 2024 18:49
Copy link
Contributor

@pauldumais pauldumais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irvingoujAtDevolution irvingoujAtDevolution merged commit 55d3749 into master Apr 17, 2024
20 checks passed
@irvingoujAtDevolution irvingoujAtDevolution deleted the dgw-analytics branch April 17, 2024 14:40
@CBenoit
Copy link
Member

CBenoit commented Apr 18, 2024

note: The scope for this PR/commit should be webapp instead of dgw (should be adjusted when redacting the release notes, cc @thenextman)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants