-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webapp): check if a new version is available #757
Conversation
Is there a Jira ticket for this? This should be added in the final commit as a footer like so: This commit should also follow the conventional commit specification. If all of this is done properly, the change will be properly documented automatically in our changelog when it’s time to cut a new release. For example: Failing at following this convention is making it harder to maintain the changelog properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good to me, but maybe @kristahouse can have a deeper look?
My comments above are mostly on the form. Feel free to merge, but try to follow the convention to ease the future releases. Thank you!
Will do, I used github cli to automatically fills up the title, used it wrong obviously. Will pay extra attention on it next time. |
Just to follow up. The patch LGTM! Thanks @irvingoujAtDevolution! |
Added tooltip. Changed the interceptor logic, now, it will not add auth header for all request to third party url