fix(webapp): improve the error catching for VNC and ARD #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBenoit
reviewed
Mar 4, 2024
webapp/src/client/app/modules/web-client/vnc/web-client-vnc.component.ts
Show resolved
Hide resolved
webapp/src/client/app/modules/web-client/vnc/web-client-vnc.component.ts
Outdated
Show resolved
Hide resolved
webapp/src/client/app/modules/web-client/vnc/web-client-vnc.component.ts
Outdated
Show resolved
Hide resolved
CBenoit
changed the title
|
@kristahouse the parsing logic should be handled by the WASM module since this PR: #744 |
kristahouse
force-pushed
the
DGW-157-Web-app-Improve-error-catching-for-VNC-ARD
branch
from
e260e5d to
0a34ec9
Compare
|
Removed parsing logic from web app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: DGW-157