fix(dgw): polish scanner, fix issues

[irvingoujAtDevolution]

fixes the folloing issue

1. this should stop error message from mdns_sd
2. scanner should be stopped correctly now, let me know if on your side @CBenoit

Issue: DGW-131

[CBenoit]

It’s now closing but not in a clean way. Everything should be good if you add this line:

index 440d2f5..4b58f17 100644
--- a/devolutions-gateway/src/api/net.rs
+++ b/devolutions-gateway/src/api/net.rs
@@ -74,6 +74,8 @@ pub async fn handle_network_scan(
         info!("Network scan finished");

         stream.stop();
+
+        let _ = websocket.close().await;
     });

     Ok(res)

[irvingoujAtDevolution]

It’s now closing but not in a clean way. Everything should be good if you add this line:

index 440d2f5..4b58f17 100644
--- a/devolutions-gateway/src/api/net.rs
+++ b/devolutions-gateway/src/api/net.rs
@@ -74,6 +74,8 @@ pub async fn handle_network_scan(
         info!("Network scan finished");

         stream.stop();
+
+        let _ = websocket.close().await;
     });

     Ok(res)

I added this at where the stream receives none

[CBenoit]

I added this at where the stream receives none

Why not just keep this at the end?

stream.stop();

let _ = websocket.close().await;

This looks less error-prone to me. Is it causing any problem?

[irvingoujAtDevolution]

I added this at where the stream receives none

Why not just keep this at the end?

stream.stop();

let _ = websocket.close().await;

This looks less error-prone to me. Is it causing any problem?

Not really, it‘s just the logic to me. looks more precise, if the select ends because of the second branch, where the client sends close message, it feels not right to send back a message on a closed connection. Though, it practially makes little difference.