perf(dgw): re-use TLS client config #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of rustls 0.21, it’s possible to disable the TLS resumption that is not supported by some services such as CredSSP. This allow us to reuse the same TLS client config and connector for all proxy-based TLS connections. (TlsConnector is just a wrapper around the config providing the `connect` method.) > Making one of these can be expensive, and should be once per process > rather than once per connection. [source](https://docs.rs/rustls/0.21.1/rustls/client/struct.ClientConfig.html)
CBenoit
force-pushed
the
optimize-tls-connect
branch
from
37eaa50 to
6b43551
Compare
awakecoding
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of rustls 0.21, it’s possible to disable the TLS resumption that is not supported by some services such as CredSSP.
This allow us to reuse the same TLS client config and connector for all proxy-based TLS connections.
(TlsConnector is just a wrapper around the config providing the
connectmethod.)source