Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dgw): do not enforce scheme in /jet/fwd #430

Merged
merged 1 commit into from
May 8, 2023

Conversation

CBenoit
Copy link
Member

@CBenoit CBenoit commented May 8, 2023

This was inconsistent with other routes such as /jet/jmux where dst_hst will have the http or https scheme, but this is simply used as a filter policy and Devolutions Gateway will not wrap the stream further into an "https protocol layer".

Instead, we rely on the requested uri to choose between plain TCP and TLS wrapping at proxy level (i.e.: /jet/fwd/tcp vs /jet/fwd/tls).

@CBenoit CBenoit requested a review from a team May 8, 2023 15:09
@CBenoit CBenoit enabled auto-merge (squash) May 8, 2023 15:10
This was inconsistent with other routes such as /jet/jmux where
`dst_hst` will have the `http` or `https` scheme, but this is
simply used as a filter policy and Devolutions Gateway will not
wrap the stream further into an `https` protocol layer.

Instead, we rely on the requested uri to choose between plain TCP
and TLS wrapping at proxy level (i.e.: /jet/fwd/tcp vs /jet/fwd/tls).
@CBenoit CBenoit force-pushed the remove-tls-scheme-check branch from baead32 to c18c6aa Compare May 8, 2023 17:06
@CBenoit
Copy link
Member Author

CBenoit commented May 8, 2023

Rebased on master.

@CBenoit CBenoit merged commit 54e467f into master May 8, 2023
@CBenoit CBenoit deleted the remove-tls-scheme-check branch May 8, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants