Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: include most recent typings with this repo #3

Closed
CHBaker opened this issue Mar 19, 2019 · 2 comments
Closed

FEATURE: include most recent typings with this repo #3

CHBaker opened this issue Mar 19, 2019 · 2 comments

Comments

@CHBaker
Copy link

CHBaker commented Mar 19, 2019

I believe it would be beneficial to make this repo function with @types/cesium from definitelytyped as well. I could include that in the docs pull also.

only one issue, it has stopped working suddenly, I'm tracking an issue with repro steps here

if you have any idea on fixes for this we could work it out together, and this would be a great resource for Angular Typescript Cesium users

@bampakoa
Copy link
Member

@CHBaker that is a nice idea but consider this:

  1. These are not official typings from Cesium. There is an effort that has began to create official types from within the Cesium code, based on the JSDoc tags. You can find more details here Add "Typings" file to NPM package for Typescript consumers CesiumGS/cesium#5717 (comment)
  2. It is preferable to let the end users decide upon the types that will use (they could have even created their own types)

On the other hand, we could mention on the docs about the existence of typings in the types repository and how can be used in this example. What do you think?

@CHBaker
Copy link
Author

CHBaker commented Mar 19, 2019

Sounds good to me, I see your point. I have seen that issue, it seems there is a race on who finishes typings first, then it will be integrated on both ends

@CHBaker CHBaker closed this as completed Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants