Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to bypass starting requirements #2197

Closed
2 tasks done
nathan-mittelette opened this issue Nov 27, 2022 · 5 comments · Fixed by #2198
Closed
2 tasks done

Allow to bypass starting requirements #2197

nathan-mittelette opened this issue Nov 27, 2022 · 5 comments · Fixed by #2198
Labels
enhancement New feature or request
Milestone

Comments

@nathan-mittelette
Copy link
Contributor

nathan-mittelette commented Nov 27, 2022

Current Behavior

Currently, when trying to start the dependency-track API, if your system does not meet the required requirements, the application will not start.

This behavior can force you to allocate a lot of resources.

Proposed Behavior

I suggest keeping the current behavior but allowing the user to easily override the requirements using an environment variable.
We can create an system.requirements.bypass environment variable. By default, this variable will be set to false. But it can be replaced by true if we want to bypass this mechanism.

Checklist

@stevespringett
Copy link
Member

This behavior can force you to allocate a lot of resources.

I know "a lot" is subjective, but I don't think 4.5 GB and 2 cores is "a lot". The system will not function correctly below 3GB.

https://docs.dependencytrack.org/getting-started/deploy-docker/

@nathan-mittelette
Copy link
Contributor Author

I understand, but currently in my company we are running dependency-track API with 2Gi and 1 CPU because we don't have huge projects that needs a lot of memory while doing scans. Using dependency-track with this setup isn't perfect, but it's sufficient for our use.
Maybe if we allow users to bypass the requirements with obviously an warning at the start, that might help in some cases.

@nscuro
Copy link
Member

nscuro commented Nov 29, 2022

IMO it's OK to provide the ability to opt out of this restriction.

Ideally we would have recommendations as to what workload requires (approximately) how many resources. But we don't currently.

At the moment we have users modifying DT internally to disable the check, and DT runs fine for them. There were multiple occasions in Slack where this was mentioned.

@nathan-mittelette
Copy link
Contributor Author

At the moment we have users modifying DT internally to disable the check, and DT runs fine for them. There were multiple occasions in Slack where this was mentioned.

Yes, it's exactly what we've done in my company, and I taught that we may not be alone and it can be useful to provide an implementation to properly disable the check.

@nscuro nscuro added this to the 4.7 milestone Dec 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants