Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugrid3d: collection of remarks #310

Open
Huite opened this issue Jan 27, 2025 · 0 comments
Open

Ugrid3d: collection of remarks #310

Huite opened this issue Jan 27, 2025 · 0 comments

Comments

@Huite
Copy link
Collaborator

Huite commented Jan 27, 2025

I'm taking a cursory glance at what's required for fully unstructured 3D support according to UGRID conventions.

Z-coordinate

I'm making a distinction between lat-lon and x-y (is_projected / is_geographic). It looks like another distinction is required for the direction of the z axis positive_up.

    "node_z": {
        PROJECTED: {
            "standard_name": "projection_z_coordinate",
        },
        LATLON: {
              UP: {"standard_name": "height"},
              DOWN: {"standard_name": "depth"},
        },

There's a whole slew of names to consider:

Z_STANDARD_NAMES = (
    "projection_z_coordinate",  # Simple Cartesian
    "height",                  # Height above surface
    "depth",                   # Depth below surface
    "height_above_reference_ellipsoid",
    "height_above_mean_sea_level",
    "depth_below_mean_sea_level",
    "ocean_sigma_coordinate",  # Terrain-following
    "ocean_s_coordinate",      # S-coordinates
    "atmosphere_hybrid_sigma_pressure_coordinate"  # Atmospheric hybrid coordinates
)

I think projection_z_coordinate, depth and height are reasonable (terse) defaults; they're easily modified anyway.

@Huite Huite changed the title Ugrid3d: collection Ugrid3d: collection of remarks Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant