Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOP Resprite #1501

Merged
merged 17 commits into from
Jul 31, 2024
Merged

HOP Resprite #1501

merged 17 commits into from
Jul 31, 2024

Conversation

Timemaster99
Copy link
Contributor

@Timemaster99 Timemaster99 commented Jul 17, 2024

About the PR

HOP's uniform is rather outdated, as is evident by the SS13 forks which have replaced the one we currently have. This PR ports the uniform and coat from Paradise Station and adjusts some other HOP items to match.

Why / Balance

Technical details

sprites

Media

Screenshot 2024-07-23 20-49-10
Screenshot 2024-07-23 20-49-28
Screenshot 2024-07-23 20-50-17
Screenshot 2024-07-23 20-50-50
Screenshot 2024-07-23 20-51-07
Screenshot 2024-07-23 20-51-30
Screenshot 2024-07-23 20-51-49
Screenshot 2024-07-23 20-52-20
Screenshot 2024-07-23 20-53-46

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Head of Personnel has received new uniforms from their tailor.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

RSI Diff Bot; head commit 02731b0 merging into 00ae128
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/OuterClothing/Coats/hop.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon Modified

Resources/Textures/DeltaV/Clothing/OuterClothing/Coats/repcoat.rsi

State Old New Status
equipped-OUTERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/hopmesskit.rsi

State Old New Status
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/boatswain.rsi

State Old New Status
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/hopmesskit.rsi

State Old New Status
equipped-INNERCLOTHING Modified
icon Modified
inhand-left Modified
inhand-right Modified

Resources/Textures/DeltaV/Clothing/Head/Hats/hopcap.rsi

State Old New Status
equipped-HELMET-hamster Added
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Neck/Cloaks/hop.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Neck/mantles/hopmantle.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/hop.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING Added
icon Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/hop.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING Added
icon Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/hopformal.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added

Edit: diff updated after 02731b0

@Timemaster99
Copy link
Contributor Author

Test fail unrelated

@ps3moira
Copy link
Contributor

Unless we're porting everything from paradise, the color pallets of this resprite doesn't fit the rest of the stations current art style that much.

@Timemaster99
Copy link
Contributor Author

Timemaster99 commented Jul 18, 2024

Unless we're porting everything from paradise, the color pallets of this resprite doesn't fit the rest of the stations current art style that much.

I'm inclined to disagree. This seems to line up much better than very bright, unshaded default HOP suit
image
image
image

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jul 22, 2024
@ghost
Copy link

ghost commented Jul 23, 2024

Here's my take on this resprite:
While I want to strive for Paradise as a vision - my one nitpick with bringing this here is the hat. I like the HoP's current hat and the hat that's part of this resprite clashes and it feels like its shape reinforces HoP's existence as second in command to Captain, which it isn't here, since HoP only has service accesses. I also suppose that Moira has a point, but you did state you were inclined to disagree, so

@Timemaster99
Copy link
Contributor Author

Here's my take on this resprite: While I want to strive for Paradise as a vision - my one nitpick with bringing this here is the hat. I like the HoP's current hat and the hat that's part of this resprite clashes and it feels like its shape reinforces HoP's existence as second in command to Captain, which it isn't here, since HoP only has service accesses. I also suppose that Moira has a point, but you did state you were inclined to disagree, so

2024-07-22.23-22-43.mp4

image

Thoughts?

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jul 23, 2024
@Timemaster99 Timemaster99 changed the title HOP Resprite HOP Resprite (Green Edition) Jul 24, 2024
@Timemaster99
Copy link
Contributor Author

made it green to address Adei's concerns about second in command

@ghost
Copy link

ghost commented Jul 24, 2024

Here's my take on this resprite: While I want to strive for Paradise as a vision - my one nitpick with bringing this here is the hat. I like the HoP's current hat and the hat that's part of this resprite clashes and it feels like its shape reinforces HoP's existence as second in command to Captain, which it isn't here, since HoP only has service accesses. I also suppose that Moira has a point, but you did state you were inclined to disagree, so

2024-07-22.23-22-43.mp4

image

Thoughts?

I love this, keep it blue, I don't want green HoP. I am pleading.

@Timemaster99
Copy link
Contributor Author

Here's my take on this resprite: While I want to strive for Paradise as a vision - my one nitpick with bringing this here is the hat. I like the HoP's current hat and the hat that's part of this resprite clashes and it feels like its shape reinforces HoP's existence as second in command to Captain, which it isn't here, since HoP only has service accesses. I also suppose that Moira has a point, but you did state you were inclined to disagree, so

2024-07-22.23-22-43.mp4
image
Thoughts?

I love this, keep it blue, I don't want green HoP. I am pleading.

I'm personally neither here nor there. I just want to make sure it's easy for new players to tell the difference. Lyndo is leading the discussion, so if a negative consensus is reached, I made sure that Green HOP is one simple revert away from turning blue again.

@Lyndomen
Copy link
Contributor

There isn't a solid consensus either way, opinions seem pretty deadlocked.

@Timemaster99
Copy link
Contributor Author

There isn't a solid consensus either way, opinions seem pretty deadlocked.

I will settle on this: I will revert green hop in exchange for the quick merge of this, and then leave another green PR open for discussion

@Timemaster99 Timemaster99 changed the title HOP Resprite (Green Edition) HOP Resprite Jul 24, 2024
@Timemaster99
Copy link
Contributor Author

Here's my take on this resprite: While I want to strive for Paradise as a vision - my one nitpick with bringing this here is the hat. I like the HoP's current hat and the hat that's part of this resprite clashes and it feels like its shape reinforces HoP's existence as second in command to Captain, which it isn't here, since HoP only has service accesses. I also suppose that Moira has a point, but you did state you were inclined to disagree, so

2024-07-22.23-22-43.mp4
image
Thoughts?

I love this, keep it blue, I don't want green HoP. I am pleading.

Ready if you want to merge

@Colin-Tel Colin-Tel merged commit 617eac5 into DeltaV-Station:master Jul 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants