Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security Magboots #1490

Closed
wants to merge 10 commits into from
Closed

Conversation

ProphetCrow
Copy link

@ProphetCrow ProphetCrow commented Jul 12, 2024

About the PR

Adds Security Mag Boots

Why / Balance

Gives security EVA magboots and slip resistance, 20% movement speed penalty when activated , which is statistically identical to engineering magboots.

Technical details

Added files, adjusted suit_storage yml file in main prototypes catalog

Media

https://cdn.discordapp.com/attachments/1010560161888350340/1261395908130639942/Delta-v_2024-07-12_14-49-55.mp4?ex=6692cdfc&is=66917c7c&hm=696963dad70232ebe0711f288bfe09cde1859c071425f1bd0705e0ccda78ce97&
/ https://discord.com/channels/968983104247185448/1010560161888350340/1261395910152163378

  • [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None

Changelog

🆑 Crow

  • add: Security Magboots

Signed-off-by: ProphetCrow <[email protected]>
Signed-off-by: ProphetCrow <[email protected]>
Signed-off-by: ProphetCrow <[email protected]>
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Jul 12, 2024
Copy link
Contributor

github-actions bot commented Jul 12, 2024

RSI Diff Bot; head commit 233183f merging into 353eb66
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Shoes/Boots/magboots-security.rsi

State Old New Status
equipped-FEET Added
icon-on Added
icon Added
inhand-left Added
inhand-right Added
on-equipped-FEET Added
on-inhand-left Added
on-inhand-right Added

Edit: diff updated after 233183f

Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring that these are INSANELY unbalanced; and will be a Security DREAM.

Two issues, test fail aside :)

Changelog also needs fixing; and there are no breaking changes here.

ProphetCrow and others added 2 commits July 12, 2024 18:03
…ty.rsi/meta.json

Co-authored-by: Danger Revolution! <[email protected]>
Signed-off-by: ProphetCrow <[email protected]>
attempted fix

Signed-off-by: ProphetCrow <[email protected]>
@WarMechanic
Copy link
Contributor

the sprite is nice :)

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Aug 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@BlitzTheSquishy
Copy link
Contributor

As a sec main

Tie it to research rather than being round start

cause like engi always wearing theirs, sec will do the same - mitigate powergaming

@TadJohnson00
Copy link
Contributor

Is this PR still being worked on or is it abandoned @ProphetCrow ?

@deltanedas
Copy link
Member

Tie it to research

they can already ask epi to make researched magboots

@Samsterious
Copy link
Contributor

While I think Security should have access to magboots for EVA, we all know every SecOff is going to speedrun grabbing these out of the lockers if they are available, and that completely defeats one of the most effective ways of dealing with Security on your tail without harming them. This PR makes sense, but I also think it introduces a massive balance issue that far outweighs that fact.

@TadJohnson00
Copy link
Contributor

Going to assume this is abandoned, no activity after two months and no reply after two weeks.

@Radezolid Radezolid mentioned this pull request Oct 30, 2024
2 tasks
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
# Description
this ports the following PRs:
TheDenSS14/TheDen#128
TheDenSS14/TheDen#133
TheDenSS14/TheDen#135
TheDenSS14/TheDen#143

Essentially, this PR adds several new "Civilian Grade" firearms to the
game that come from Frontier, most of which use the new LightRifle
cartridge, a fairly underpowered round. Security can take the new
Argenti revolver in their loadouts, while Salvage can spend their Mining
Points on the civilian rifles. Notably, the ones purchased in the Mining
Vendor do not come with ammo. Salvage needs to go request ammo from
Security, or a traitor salvage can emag the cargo autolathe to get ammo
for them.

I'm going to laugh my ass off the first time a Warden has to deal with
Salvage specialists coming to ask "Hey can you print me ammo for my
MOSIN?"

<details><summary><h1>Media</h1></summary>
<p>

New 0 point revolver for sec. It does shit-tier damage since it fires
.20 rifle, but with an 8 round capacity, it's the highest capacity
revolver in the game.

![image](https://github.com/user-attachments/assets/403acae6-deb9-4ef6-b5f4-dab5201d8009)

![image](https://github.com/user-attachments/assets/7ea66718-837c-489e-8da3-5ef60c25e33a)

New salvage vendor "Civilian Grade" equipment

![image](https://github.com/user-attachments/assets/6723f2f7-cf7b-438e-b9b7-2df108d20336)

Tested and verified that the salvage vendor guns actually do spawn
empty:

![image](https://github.com/user-attachments/assets/ea0eb959-2815-4a5b-87ce-d0654b74133f)

</p>
</details>

# Changelog

:cl:
- add: Added the Argenti, Gestio, Novalite C1, and SVT firearms. Added
an "Empty" Mosin variant for Salvage.
- add: Salvage technicians can now spend their mining points on new
"Civilian Grade" firearms from the Mining Vendor. These don't come with
ammo, so you'll have to request ammo be printed by Security.
- add: Added the Argenti Revolver to Security Loadouts.
- tweak: Salvage Specialist lockers are now guaranteed to come with one
pickaxe and one ore bag.

---------

Co-authored-by: sleepyyapril <[email protected]>
Co-authored-by: Rosycup <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Merge Conflict Fix your PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants