Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Senior ID cards get a custom job name #1218

Merged

Conversation

NullWanderer
Copy link
Contributor

About the PR

Makes it actually worth taking, as it isn't just a resprite in the loadout

Changelog
🆑

  • tweak: Senior PDA's now have an ID card with a custom job title

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files labels May 18, 2024
@NullWanderer
Copy link
Contributor Author

Gotta make some more changes so it syncs with station records

@NullWanderer
Copy link
Contributor Author

image
image
Works as intended now

@NullWanderer NullWanderer marked this pull request as ready for review May 18, 2024 14:23
@WarMechanic
Copy link
Contributor

This is a godsend for me as I enjoy teaching others engineering. Looking forward to seeing it implemented.

@redmushie

This comment was marked as abuse.

@ProphetCrow

This comment was marked as off-topic.

@NullWanderer
Copy link
Contributor Author

customJob just sounds better, I would've done just job, but it was already taken

@NullWanderer NullWanderer merged commit 72853c1 into DeltaV-Station:master May 18, 2024
12 checks passed
@Timemaster99 Timemaster99 mentioned this pull request May 18, 2024
1 task
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

One word change; silver was named incorrectly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants