Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mass sleep can instantly be woken up from #1433

Closed
deltanedas opened this issue Jun 26, 2024 · 7 comments
Closed

mass sleep can instantly be woken up from #1433

deltanedas opened this issue Jun 26, 2024 · 7 comments
Labels
Priority: 2-High Needs to be resolved as soon as possible size/S 16-63 lines

Comments

@deltanedas
Copy link
Member

Description

its basically a psychic pie throw
@github-actions github-actions bot added the S: Untriaged This issue or PR needs labelling label Jun 26, 2024
@DangerRevolution
Copy link
Contributor

recreation? any PR's that could've caused this?

@deltanedas
Copy link
Member Author

i believe it appeared after an upstream merge that changed sleep code

@DangerRevolution
Copy link
Contributor

i believe it appeared after an upstream merge that changed sleep code

:(

@deltanedas
Copy link
Member Author

deltanedas commented Jun 26, 2024 •
edited
Loading

also another bug it raises glimmer even if nobody is slept by it + has full cooldown too

@deltanedas deltanedas added size/S 16-63 lines Priority: 2-High Needs to be resolved as soon as possible and removed S: Untriaged This issue or PR needs labelling labels Jun 26, 2024
@UnicornOnLSD
Copy link
Contributor

my absolutely overpowered instant stun click power isn't overpowered anymore ? impossible.

@Squishy77
Copy link
Contributor

I made a pr that added nospheirc zap as the same rarity as mass sleep, it would do a stun baton stun on one target instead of many, I feel like this could balance it out in a way.

@DangerRevolution DangerRevolution mentioned this issue Jul 10, 2024
Closed
@ghost
Copy link

ghost commented Aug 18, 2024

will be fixed by #1649 when that's done

@MilonPL MilonPL closed this as completed Sep 23, 2024
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this issue Jan 11, 2025
@angelofallars @VMSolidus
Pacification Prevents Throwing Weapons (DeltaV-Station#1433)
71e3c03 
# Description

Prevents entities who are Pacified (through the Pacifist trait or being
a thief) from throwing items that deal damage on hit or embed.

## Technical Details

Two components will prevent throwing if they deal any damage:
`DamageOtherOnHitComponent` and `EmbedPassiveComponent`.

The pacifist check on `EmbeddableProjectileComponent` has been removed,
because just because an item is embeddable does not mean they deal
damage.

## Media

**Throw attempt with the Pacifist trait**


![image](https://github.com/user-attachments/assets/6c439bb3-b41b-4f30-975d-4fa15c2cfa6d)


# Changelog

:cl: Skubman
- fix: Pacified characters (Pacifist trait and thieves) can no longer
throw items that deal throwing damage.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this issue Jan 11, 2025
@SimpleStation14
Automatic Changelog Update (DeltaV-Station#1433)
06be5d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: 2-High Needs to be resolved as soon as possible size/S 16-63 lines
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@deltanedas @MilonPL @DangerRevolution @UnicornOnLSD @Squishy77