Is it ok to pull request partial definition for CKEditor?

[ondrejsevcik]

Hi, I'm working on CKEditor definition file, but Its not complete yet. CKEditor is huge and I'm not sure if I ever finish it. It's usable but some parts are not finished. Is it ok to pull request this partial definition? Thanks

https://github.com/ondrejsevcik/ckeditor-typedefinitions

[johnnyreilly]

Hi @ondrejsevcik,

I'd say that's fine. People are more likely to add to an existing definition that someone has started than they are to start from scratch. That's open source in the best sense of the term I think.

If you could try and include a tests file as well that would be greatly appreciated.

[ondrejsevcik]

Thanks, I make test file and push :)

[Bartvds]

@ondrejsevcik You could put a work-in-progress comment in the top of the definitions file. And maybe a link to this thread so people can message about it or drop a note if they decide to expand your partial.

[keyiis]

@ondrejsevcik i installed ckeditor.d.ts,but not work,below is my work step
step1: npm install ckeditor --save
step2: typings install dt~ckeditor --save --global
step3: in ts file,i import ckeditor

import {CKEDITOR} from 'ckeditor';
error:[ts] Cannot find module 'ckeditor'.

[304NotModified]

FYI,

we needed to type myClass.getContentWindow().CKEDITOR, where getContentWindow() returns Window

We did it like this:

interface Window {
   CKEDITOR: typeof CKEDITOR;
}

[Enquier]

For anyone interested in this, I have posted a further expansion of these types that should help to continue expanding and adding plugins

#63591