Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency with new classes DeeplClient and DeeplClientOptions. #59

Closed
VincentLanglet opened this issue Jan 16, 2025 · 2 comments
Closed

Comments

@VincentLanglet
Copy link
Contributor

Hi @JanEbbing

I saw you introduced a new DeeplClient classes which is supposed to be used instead of Translator.
cf 46b68a7

There is also a DeeplClientOptions class, but I don't see why it extends TranslateTextOptions.
Shouldn't it extends TranslatorOptions instead ?

In the same way I did

new Translator($apiKey, [TranslatorOptions::DEFAULT_MAX_RETRIES => 0])

i would expect now to do

new DeepLClient($apiKey, [DeeplClientOptions::DEFAULT_MAX_RETRIES => 0])

WDYT ?

@JanEbbing
Copy link
Member

Good catch sorry. I'll fix this and add a test for it

@JanEbbing
Copy link
Member

Fixed in 1.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants