Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for code standards in root of repository for PHP_CodeSniffer 3.x #26

Closed
frenck opened this issue May 10, 2017 · 1 comment
Closed
Assignees
Milestone

Comments

@frenck
Copy link
Contributor

frenck commented May 10, 2017

Problem/Motivation

PHP_CodeSniffer requires the coding standards to be in a directory, this behaviour changed in 3.x.

"The installed_paths config setting can now point directly to a standard. Previously, it had to always point to the directory in which the standard lives"

See the release notes:
https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.0.0a1

This plugin does not support this yet.

Expected behaviour

Allowing a repository with a coding standard in the root of is project to work, when PHP_CodeSniffer 3.x or newer is used.

Actual behaviour

The coding standard won't be installed by this plugin.

Proposed changes

Change the coding standards search depth based on the PHP_CodeSniffer version used.

@frenck
Copy link
Contributor Author

frenck commented May 11, 2017

Added in #30, closing issue.

@frenck frenck closed this as completed May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant