From ec20c1fea7787d6bdb559622fc585f290b7f019f Mon Sep 17 00:00:00 2001 From: Eamonn Rea Date: Wed, 31 Jul 2024 17:36:01 +0100 Subject: [PATCH] test_util: Improve type hints for `test_get_random_game_name` (#434) --- pupgui2/util.py | 6 +++--- tests/test_util.py | 14 ++++++++------ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/pupgui2/util.py b/pupgui2/util.py index 0e20ed84..76f28d51 100644 --- a/pupgui2/util.py +++ b/pupgui2/util.py @@ -885,14 +885,14 @@ def create_missing_dependencies_message(ct_name: str, dependencies: List[str]) - return tr_msg, False -def get_random_game_name(games: List[Union[SteamApp, LutrisGame, HeroicGame]]) -> str: +def get_random_game_name(games: list[SteamApp] | list[LutrisGame] | list[HeroicGame]) -> str: """ Return a random game name from list of SteamApp, LutrisGame, or HeroicGame """ if len(games) <= 0: return '' - tooltip_game_name = '' - random_game = random.choice(games) + tooltip_game_name: str = '' + random_game: SteamApp | LutrisGame | HeroicGame = random.choice(games) if type(random_game) is SteamApp: tooltip_game_name = random_game.game_name elif type(random_game) is LutrisGame: diff --git a/tests/test_util.py b/tests/test_util.py index 46b510c7..17b7ef08 100644 --- a/tests/test_util.py +++ b/tests/test_util.py @@ -3,13 +3,15 @@ from pupgui2.datastructures import SteamApp, LutrisGame, HeroicGame -def test_get_random_game_name(): - """ test whether get_random_game_name returns a valid game name """ - names = ["game", "A super cool game", "A game with a very long name that is very long", "0123456789"] +def test_get_random_game_name() -> None: - steam_app = [SteamApp() for _ in range(len(names))] - lutris_game = [LutrisGame() for _ in range(len(names))] - heroic_game = [HeroicGame() for _ in range(len(names))] + """ Test whether get_random_game_name returns a valid game name for each launcher game type. """ + + names: list[str] = ["game", "A super cool game", "A game with a very long name that is very long", "0123456789"] + + steam_app: list[SteamApp] = [SteamApp() for _ in range(len(names))] + lutris_game: list[LutrisGame] = [LutrisGame() for _ in range(len(names))] + heroic_game: list[HeroicGame] = [HeroicGame() for _ in range(len(names))] for i, name in enumerate(names): steam_app[i].game_name = name