Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolCount-on-service-Assignment #189

Merged
merged 3 commits into from
May 18, 2024
Merged

Conversation

DaveLuhman
Copy link
Owner

@DaveLuhman DaveLuhman commented May 18, 2024

This change is Reviewable

Subject: Enhance Service Assignment with Tool Count

Added 'toolCount' field to ServiceAssignment model for better resource tracking, enforcing a minimum value of 0 to ensure data integrity. Updated the enum values within the ServiceAssignment Schema to more accurately reflect the types of jobsites, changing 'Contract Job' and 'Service Job' to 'Contract Jobsite' and 'Service Jobsite,' respectively. This change clarifies the nature of the assignments in the system. Service assignment fetch operation is now more performance-efficient by using `.lean()` with the query to speed up data retrieval, beneficial for large datasets. Furthermore, the 'toolCount' field is now displayed in the service assignments settings view, with a visual emphasis on counts greater than zero, improving the user interface for site administrators by allowing quick identification of resource allocations per assignment.

This integration offers a detailed insight into the resource distribution across different service assignments, facilitating better planning and resource management.

Resolves:  add toolCount to ServiceAssignment model and settings page. #187
Copy link
Contributor

deepsource-io bot commented May 18, 2024

Here's the code health analysis summary for commits e1da396..f7ea4e2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@DaveLuhman DaveLuhman merged commit 11540de into master May 18, 2024
4 of 5 checks passed
@DaveLuhman DaveLuhman deleted the toolCount-on-service-Assignment branch May 18, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant