Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete process config file if not configured #703

Merged
merged 1 commit into from
May 25, 2021
Merged

delete process config file if not configured #703

merged 1 commit into from
May 25, 2021

Conversation

yanjunding
Copy link
Contributor

What does this PR do?

If there are no configured processes, the configuration file will be

---
init_config: {}
instances: []

The config check will return error, as

=== Configuration errors ===
process: Configuration file contains no valid instances

Motivation

It happens in our project, and it's annoying

Additional Notes

Describe your test plan

@yanjunding yanjunding requested a review from a team as a code owner May 24, 2021 23:40
@yanjunding
Copy link
Contributor Author

on datadog web, it shows,
image

@yanjunding
Copy link
Contributor Author

Having been done for a few configuration testing, if the conf.yaml file is exsting, and no processes configured.
It will cause error

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thanks for the PR! It looks good to me

@mx-psi mx-psi merged commit f48eb28 into DataDog:master May 25, 2021
@yanjunding yanjunding deleted the fix_noprocess branch May 25, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants