Pass proxy configuration from agent_extra_options to dogapi #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the Agent is configured to use a proxy, use the same proxy when calling dogapi to send puppet reports. Tested by modifying dogapi to log the value of the proxy and checking the value in agent_extra_options got there.
KSerrania
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In case the Agent is configured to use a proxy, use the same proxy when calling dogapi to send puppet reports.
Motivation
When behind a proxy, users had to configure it twice: once in their puppet manifest for the Agent to use, and another time as environment variables for puppetserver (which ends up calling dogapi). This makes the second step no longer needed.
Additional Notes
This is technically a breaking change, but I can't imagine a scenario where the previous behaviour is wanted.
Describe your test plan
Tested by modifying dogapi to log the value of the proxy and checking the value in agent_extra_options got there.