[disk] add support for new options #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
remeh
approved these changes
Mar 25, 2019
manifests/integrations/disk.pp
Outdated
| Optional[Array[String]] $mountpoint_whitelist = undef, | ||
| Optional[Variant[String, Array[String]]] $excluded_filesystems = undef, # deprecated in agent versions >6.9 | ||
| Optional[Variant[String, Array[String]]] $excluded_disks = undef, # deprecated in agent versions >6.9 | ||
| Optional[Variant[String, Array[String]]] $excluded_disk_re = undef, # deprecated in agent versions >6.9 |
There was a problem hiding this comment.
Even if deprecated, I may be wrong but it looks like the Array variant isn't managed in the erb? Same goes for excluded_mountpoint_re. Please discard if I'm wrong.
There was a problem hiding this comment.
No, you're right, these were strings in the past! Thank you 🙇
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
* [disk] add support for new options * [disk] fix optional type for deprecated types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some options have been deprecated for the disk integration in recent versions of the agent. This PR adds support for the newer options, all while keeping the old ones for customers who may still be pinned to prior versions.