Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh_check.d instead of ssh.d #502

Merged
merged 2 commits into from
Mar 14, 2019
Merged

ssh_check.d instead of ssh.d #502

merged 2 commits into from
Mar 14, 2019

Conversation

cabrinha
Copy link
Contributor

@cabrinha cabrinha commented Mar 8, 2019

https://docs.datadoghq.com/integrations/ssh_check

The SSH integration needs to be updated to create the ssh conf.yaml in the correct location.

Error: Could not set 'file' on ensure: No such file or directory @ dir_s_mkdir - /etc/datadog-agent/conf.d/ssh.d/conf.yaml20190308-4494-1k41zhp.lock at /etc/puppetlabs/code/environments/production/modules/datadog_agent/manifests/integrations/ssh.pp:50
Error: /Stage[main]/Datadog_agent::Integrations::Ssh/File[/etc/datadog-agent/conf.d/ssh.d/conf.yaml]/ensure: change from absent to file failed: Could not set 'file' on ensure: No such file or directory @ dir_s_mkdir - /etc/datadog-agent/conf.d/ssh.d/conf.yaml20190308-4494-1k41zhp.lock at /etc/puppetlabs/code/environments/production/modules/datadog_agent/manifests/integrations/ssh.pp:50

The correct path is:
/etc/datadog-agent/conf.d/ssh_check.d/conf.yaml.example

@cabrinha
Copy link
Contributor Author

cabrinha commented Mar 13, 2019

We also need to update the tests to account for the directory ssh_check.d over ssh.d

I'm unsure if datadog-agent v5 uses ssh.conf instead of ssh_check.conf but it seems that since the tests have passed, all should be well.

@truthbk

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇

@truthbk truthbk merged commit b8adc84 into DataDog:master Mar 14, 2019
@truthbk truthbk added this to the 2.5.0 milestone Mar 25, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
* ssh_check.d instead of ssh.d

* conf_file should be set to ssh_check.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants