Make it possible to enable PostgreSQL extra metrics collection #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogokiss
force-pushed
the
postgres-collect-metrics
branch
3 times, most recently
from
bb85bf7 to
d351acb
Compare
The current version of the PostgresSQL module integration doesn't handle the following parameters for the Datadog PostgreSQL integration: * collect_function_metrics * collect_count_metrics * collect_activity_metrics * collect_database_size_metrics This way metrics like postgresql.active_queries and postgresql.waiting_queries, for example, were not available. This change aims to make them available whenever desired.
|
Hi, @truthbk! Should I assign someone to review this PR or should I just wait until the team finds a suitable time for that? |
|
Took a quick look at the PR and it looks pretty good at a glance. Thank you for adding those tests. I'll give it a detailed pass soon (specifically at the defaults and verify they're sane) - thank you for adding those tests, that really helps @diogokiss Assigning myself. |
|
You're welcome, @truthbk. And thanks for checking it. Please, let me know if there is anything I need/can improve. |
truthbk
approved these changes
Feb 4, 2019
| String $username = 'datadog', | ||
| Boolean $ssl = false, | ||
| Boolean $use_psycopg2 = false, | ||
| Boolean $collect_function_metrics = false, |
There was a problem hiding this comment.
defaults here are all sane and consistent with integration defaults 👍
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…og#493) The current version of the PostgresSQL module integration doesn't handle the following parameters for the Datadog PostgreSQL integration: * collect_function_metrics * collect_count_metrics * collect_activity_metrics * collect_database_size_metrics This way metrics like postgresql.active_queries and postgresql.waiting_queries, for example, were not available. This change aims to make them available whenever desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the PostgresSQL module integration doesn't
handle the following parameters for the Datadog PostgreSQL integration:
This way metrics like postgresql.active_queries and postgresql.waiting_queries,
for example, were not available.
This change aims to make them available whenever desired.