Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vagrant-based testing environment #462

Merged
merged 5 commits into from
Nov 4, 2018
Merged

Conversation

remicalixte
Copy link
Contributor

This can help to test locally while developing the module

 with '#' will be ignored, and an empty message aborts the commit.
@remicalixte remicalixte force-pushed the remicalixte/test-environment branch from b9304d5 to 6ed29bb Compare October 3, 2018 18:58
@remicalixte
Copy link
Contributor Author

@truthbk Can you look at this please. I've used for a bunch of puppet PRs and I think it is really more convenient for testing than the terraform environment

Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @remicalixte

@truthbk truthbk merged commit 23c71bb into master Nov 4, 2018
@truthbk truthbk deleted the remicalixte/test-environment branch November 4, 2018 14:42
@truthbk truthbk added this to the 2.4.0 milestone Dec 20, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Apr 6, 2020
* Add vagrant-based testing environment

 with '#' will be ignored, and an empty message aborts the commit.

* Update gitignore

* Use versions in Puppetfile

* Fix some paths in the readme

* improve readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants