Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a generic define for creating modules #233

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Sep 20, 2016

There is one already but only allows one since its a class we can not do
a bunch of integrations and replace the class with this. Also this will
allow you to write ruby, or hiera and put it in the config you need.

Supersedes #141 - it's still all @cwood work. His PR had been sitting there for so long I felt bad asking him to do this for us. This just rebases to the latest master and makes sure the CI passes.

Thank you @cwood!

There is one already but only allows one since its a class we can not do
a bunch of integrations and replace the class with this. Also this will
allow you to write ruby, or hiera and put it in the config you need.
@cwood
Copy link
Contributor

cwood commented Sep 20, 2016

@truthbk I have some other stuff that we have been using at bitbucket. This has been essential since we have stopped using any of the class intergrations and just use the heira way of datadog_agent::intergrations -> define intergration and plop out the yaml file.

If you need any help I can do what I can.

@truthbk
Copy link
Member Author

truthbk commented Sep 20, 2016

CI is failing on older puppet versions... working on a fix.

@truthbk truthbk force-pushed the jaime/generic-integration branch 4 times, most recently from e64368f to a58b9e3 Compare September 20, 2016 19:51
@truthbk truthbk force-pushed the jaime/generic-integration branch from a58b9e3 to 9d77765 Compare September 20, 2016 19:57
@truthbk
Copy link
Member Author

truthbk commented Sep 20, 2016

So the YAML parser is dumping different yaml when the puppet gem is < 4.0.0. Added a patch that fixes the spec tests and takes into account both versions (legacy and PE/POSS(>=4.x)).

@cwood should we merge this? Or there's additional work you were referring to above that you would like to add? Can we merge this and then you can add on top, or would we need to write a PR from scratch.

Thanks!

@cwood
Copy link
Contributor

cwood commented Sep 20, 2016

@truthbk there is some more we have added. I have also redun the way to manage tags and making them resources vs just combining them together. I can submit that as another PR. it is using concat. We have also added a intergrations argumetn and a use_hiera argument to allow a deep merge of datadog intergrations through heira.

@mx-psi mx-psi deleted the jaime/generic-integration branch July 13, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants