datadog_agent::integrations::directory is not functional?

[kitchen]

Seems to stem from this commit

the problem is $name being reassigned.

Also, I really think the whole comment of "we do integrations as classes, not defines" doesn't make a lot of sense. In this case if you wanted to use multiple directories (which the integration seems to support, because instances (I'll admit, I have not used the integration myself, so I'm just guessing) you'd ... what?

Anywho, I'd like to fix this, but I'm not certain what the best approach is. What is $name trying to do there and why, and since it's currently non-functional, how much backward compatibility do I need to worry about?

Again, I haven't used this integration, I am working on writing tests for all of the integration classes so I can factor out a generic integration type, and ran into this issue. Please let me know how I can help :)

[gphat]

Tagging in @LeoCavaille and @talwai. 😸