fix: pragma directives not picked up on return statement #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `//dd:span` directive is not honored when it's presented on a `return` statement (where the expression is a literal function expression). This changes the directive lookup function so it crawls up to the parent if it's a node type that wraps a single expression; effectively: - `name := <expr>` (and other assignment styles) - `<call>` - `defer <call>` - `<expr>` (the expression statement) - `go <expr>` - `label: <expr>` - `return <expr>` - `ch <- <expr>` (send statement) Fixes #539
RomainMuller
force-pushed
the
romain.marcadier/directive-crawl-ups
branch
from
ba5bbf1 to
8e8fd55
Compare
RomainMuller
force-pushed
the
romain.marcadier/directive-crawl-ups
branch
from
15a8078 to
c34dde5
Compare
eliottness
approved these changes
Feb 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
- Coverage 68.03% 64.05% -3.98%
==========================================
Files 104 106 +2
Lines 6736 6917 +181
==========================================
- Hits 4583 4431 -152
- Misses 1688 2025 +337
+ Partials 465 461 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
//dd:spandirective is not honored when it's presented on areturnstatement (where the expression is a literal function expression).This changes the directive lookup function so it crawls up to the parent if it's a node type that wraps a single expression; effectively:
name := <expr>(LHS and RHS)name = <expr>(RHS only)<call>(function portion only)defer <call><expr>(the expression statement)go <expr>return <expr>ch <- <expr>(the value only)Fixes #539