From 0b24d36a4b5401405b760d0151b8863fe39899ae Mon Sep 17 00:00:00 2001 From: simon-id Date: Tue, 13 Jun 2023 17:30:23 +0200 Subject: [PATCH 1/2] add test in shimmer wrap to preserve function name --- packages/datadog-shimmer/test/shimmer.spec.js | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/packages/datadog-shimmer/test/shimmer.spec.js b/packages/datadog-shimmer/test/shimmer.spec.js index 534c74dac35..91f11786cb8 100644 --- a/packages/datadog-shimmer/test/shimmer.spec.js +++ b/packages/datadog-shimmer/test/shimmer.spec.js @@ -132,6 +132,14 @@ describe('shimmer', () => { expect(obj.count).to.have.length(3) }) + it('should preserve the original function name', () => { + const obj = { count (a, b, c) {} } + + shimmer.wrap(obj, 'count', () => () => {}) + + expect(obj.count).to.have.property(name, 'count') + }) + it('should inherit from the original prototype', () => { const obj = { count: () => {} } @@ -301,6 +309,14 @@ describe('shimmer', () => { expect(wrapped).to.have.length(3) }) + it('should preserve the original function name', () => { + const count = function count (a, b, c) {} + + const wrapped = shimmer.wrap(count, () => {}) + + expect(wrapped).to.have.property(name, 'count') + }) + it('should inherit from the original prototype', () => { const count = () => {} From 2e9ff66eb2d1b9fc5d6e37f92fb4ce4ee105d757 Mon Sep 17 00:00:00 2001 From: simon-id Date: Tue, 13 Jun 2023 17:34:57 +0200 Subject: [PATCH 2/2] Update shimmer.spec.js --- packages/datadog-shimmer/test/shimmer.spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/datadog-shimmer/test/shimmer.spec.js b/packages/datadog-shimmer/test/shimmer.spec.js index 91f11786cb8..afe475762c1 100644 --- a/packages/datadog-shimmer/test/shimmer.spec.js +++ b/packages/datadog-shimmer/test/shimmer.spec.js @@ -137,7 +137,7 @@ describe('shimmer', () => { shimmer.wrap(obj, 'count', () => () => {}) - expect(obj.count).to.have.property(name, 'count') + expect(obj.count).to.have.property('name', 'count') }) it('should inherit from the original prototype', () => { @@ -314,7 +314,7 @@ describe('shimmer', () => { const wrapped = shimmer.wrap(count, () => {}) - expect(wrapped).to.have.property(name, 'count') + expect(wrapped).to.have.property('name', 'count') }) it('should inherit from the original prototype', () => {