Suggestions

Author: iunanua

packages/dd-trace/src/telemetry/index.js

@@ -116,7 +116,7 @@ function start (aConfig, thePluginManager) {
   pluginManager = thePluginManager
   application = createAppObject()
   host = createHostObject()
-  heartbeatInterval = config.telemetry.heartbeatInterval || 60000
+  heartbeatInterval = config.telemetry.heartbeatInterval
 
   dependencies.start(config, application, host)
   sendData(config, application, host, 'app-started', appStarted())

packages/dd-trace/test/config.spec.js

@@ -786,19 +786,19 @@ describe('Config', () => {
 
     expect(config.telemetry).to.not.be.undefined
     expect(config.telemetry.enabled).to.be.true
-    expect(config.telemetry.heartbeatInterval).to.be.eq(60000)
+    expect(config.telemetry.heartbeatInterval).to.eq(60000)
     expect(config.telemetry.logCollection).to.be.false
     expect(config.telemetry.diagnosticLogCollection).to.be.false
     expect(config.telemetry.debug).to.be.false
   })
 
-  it('should not set DD_TELEMETRY_HEARTBEAT_INTERVAL', () => {
+  it('should set DD_TELEMETRY_HEARTBEAT_INTERVAL', () => {
     const origTelemetryHeartbeatIntervalValue = process.env.DD_TELEMETRY_HEARTBEAT_INTERVAL
     process.env.DD_TELEMETRY_HEARTBEAT_INTERVAL = '42'
 
     const config = new Config()
 
-    expect(config.telemetry.heartbeatInterval).to.be.eq(42000)
+    expect(config.telemetry.heartbeatInterval).to.eq(42000)
 
     process.env.DD_TELEMETRY_HEARTBEAT_INTERVAL = origTelemetryHeartbeatIntervalValue
   })

packages/dd-trace/test/telemetry/send-data.spec.js

@@ -19,8 +19,12 @@ describe('sendData', () => {
   })
 
   it('should call to request (TCP)', () => {
-    sendDataModule.sendData({ hostname: '', port: '12345', tags: { 'runtime-id': '123' } },
-      application, 'test', 'req-type')
+    sendDataModule.sendData({
+      hostname: '',
+      port: '12345',
+      tags: { 'runtime-id': '123' }
+    },
+    application, 'test', 'req-type')
     expect(request).to.have.been.calledOnce
     const options = request.getCall(0).args[1]
 
@@ -41,8 +45,11 @@ describe('sendData', () => {
   })
 
   it('should call to request (UDP)', () => {
-    sendDataModule.sendData({ url: 'unix:/foo/bar/baz', tags: { 'runtime-id': '123' } },
-      application, 'test', 'req-type')
+    sendDataModule.sendData({
+      url: 'unix:/foo/bar/baz',
+      tags: { 'runtime-id': '123' }
+    },
+    application, 'test', 'req-type')
     expect(request).to.have.been.calledOnce
     const options = request.getCall(0).args[1]
 
@@ -63,14 +70,12 @@ describe('sendData', () => {
   })
 
   it('should add debug header if DD_TELEMETRY_DEBUG is present', () => {
-    sendDataModule = proxyquire('../../src/telemetry/send-data', {
-      '../exporters/common/request': request
-    })
-
-    sendDataModule.sendData({ url: '/test',
+    sendDataModule.sendData({
+      url: '/test',
       tags: { 'runtime-id': '123' },
       telemetry: { debug: true }
-    }, application, 'test', 'req-type')
+    },
+    application, 'test', 'req-type')
 
     expect(request).to.have.been.calledOnce
     const options = request.getCall(0).args[1]