RUMM-369 Fix Carthage for Xcode 11.3 #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🐞 Fixing #71, where it was reported that
carthage update
doesn't work for Xcode 11.3.How?
Xcode 11.3
expects*.modulemap
to be put insideinclude/
directory forDatadogPrivate
.This is different in
Xcode 11.4
where*.modulemap
can be put anywhere.In result
carthage update
was failing with:💡 Why
carthage update
buildsIntegration.xcworkspace
? Well, Carthage scans recursively itsCheckouts/
directory and builds every.xcodeproj
and.xcworkspace
it finds and there is no option to make it ignore particular schemes.🎁 I also updated
spm-example
project to use1.0.2
pre-release tag, so the same problem doesn't happen there when buildingDatadog
dependency.🧪 I validated all dependency managers by running unit + UI tests:
Xcode 11.3.1 (11C505)
- OK for Carthage, Cocoapods and SPM both on 📱 and Simulator;Xcode 11.4 (11E146)
- OK for Carthage, Cocoapods and SPM both on 📱 and Simulator.💡 This PR also sets the
exactVersion
ofDatadog
SPM package used byspm-example
project to a tag on this branch. This is to make this PR correct for Xcode 11.3. We're OK with merging this tomaster
asspm-example
will be re-done soon.Review checklist